Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/export wins review css #6631

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

peterhudec
Copy link
Contributor

Description of change

This PR fixes a number of styling issues in /exportwins/review/:token, whose Nunjucks template doesn't extend from govuk/template.njk and which is using some components that still rely on global CSS provided by the govuk template.

@peterhudec peterhudec requested a review from a team as a code owner March 19, 2024 16:48
Copy link

cypress bot commented Mar 19, 2024

Passing run #52040 ↗︎

0 24 0 0 Flakiness 0

Details:

Updated visual-component test baselines
Project: data-hub-frontend Commit: b713fa007e
Status: Passed Duration: 02:10 💡
Started: Mar 20, 2024 1:26 PM Ended: Mar 20, 2024 1:28 PM

Review all test suite changes for PR #6631 ↗︎

@peterhudec peterhudec force-pushed the fix/export-wins-review-css branch from f1d8da5 to 061fcf6 Compare March 20, 2024 10:14
@peterhudec peterhudec force-pushed the fix/export-wins-review-css branch 2 times, most recently from b713fa0 to fbfefed Compare March 26, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant